smaheshwar-pltr commented on code in PR #3730:
URL: https://github.com/apache/iceberg-rust/pull/3730#discussion_r4628778802


##########
crates/iceberg/src/writer/file_writer/location_generator.rs:
##########
@@ -203,6 +207,52 @@ impl LocationGenerator for ObjectStorageLocationGenerator {
     }
 }
 
+/// Generates data file paths using the layout configured in table properties.
+///
+/// It uses [`ObjectStorageLocationGenerator`] when
+/// 
[`write.object-storage.enabled`](crate::spec::TableProperties::PROPERTY_WRITE_OBJECT_STORAGE_ENABLED)
+/// is `true`, and [`DefaultLocationGenerator`] otherwise.
+#[derive(Clone, Debug)]
+pub struct TableLocationGenerator {

Review Comment:
   I wrote up some context in 
https://github.com/apache/iceberg-rust/issues/3729 on why I've gone with this 
approach but open to change / discussion if folks have thoughts. A new 
generator here lets us keep compatibility with current client behaviour, but 
the downside is that `DefaultLocationGenerator` reads naturally yet may not do 
what's desired.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to