CTTY commented on code in PR #3730:
URL: https://github.com/apache/iceberg-rust/pull/3730#discussion_r4634911439


##########
crates/iceberg/src/writer/file_writer/location_generator.rs:
##########
@@ -203,6 +207,52 @@ impl LocationGenerator for ObjectStorageLocationGenerator {
     }
 }
 
+/// Generates data file paths using the layout configured in table properties.
+///
+/// It uses [`ObjectStorageLocationGenerator`] when
+/// 
[`write.object-storage.enabled`](crate::spec::TableProperties::PROPERTY_WRITE_OBJECT_STORAGE_ENABLED)
+/// is `true`, and [`DefaultLocationGenerator`] otherwise.
+#[derive(Clone, Debug)]
+pub struct TableLocationGenerator {

Review Comment:
   Yes, I think we should consider custom location provider here. enum seems 
like an acceptable workaround to me, but I don't want to block the custom 
location provider support for datafusion. Would appreciate more clarity here!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to