laskoviymishka opened a new pull request, #2649: URL: https://github.com/apache/iceberg-go/pull/2649
This moves `table/substrait` to `table/internal/substrait`, so `ConvertExpr`, `ConvertSchema` and `NewExtensionSet`, and the substrait-go v8 and arrow `compute/exprs` types they return, are no longer part of the exported API. It is item 8 on the v1 list, agreed in https://github.com/apache/iceberg-go/issues/2062#issuecomment-6954548038. The files move unchanged, including the tests and the embedded `functions_set.yaml`. Only the import path changes in `arrow_filter_plan.go`, `arrow_scanner.go`, `transaction.go` and `transaction_delete.go`. Filtering, scans and deletes behave the same. `releases.md` gets a compatibility note, since importers of `table/substrait` will no longer compile. `go build ./...`, `go vet ./...` and `go test ./table/...` pass, and the moved substrait tests run from their new location. The existing unreleased note about `ConvertExpr` dropping `caseSensitive` now describes a function nobody can call. I left it alone to keep this a pure move. Part of #2062. > AI-assisted, reviewed by a human. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
