zeroshade commented on code in PR #2649:
URL: https://github.com/apache/iceberg-go/pull/2649#discussion_r4645558662


##########
website/src/releases.md:
##########
@@ -120,6 +120,7 @@ Per-release notes (highlights, breaking changes, 
contributors) are published on
 - **Orphan cleanup results now expose only `OrphanFiles`.** Replace 
`result.OrphanFileLocations` with `result.OrphanFiles` (each entry has `Path` 
and `SizeBytes`). `OrphanCleanupPlan.Files()` still provides path-only lists 
during planning.
 - **Catalog identifier helper renamed.** `catalog.TableNameFromIdent` is 
removed. Use `catalog.ObjectNameFromIdent` for tables, views, and functions.
 - **Substrait expression conversion no longer takes case sensitivity.** 
`substrait.ConvertExpr(schema, expression, caseSensitive)` becomes 
`substrait.ConvertExpr(schema, expression)`. Case sensitivity remains part of 
expression binding.

Review Comment:
   Since the package isn't released yet, I'd drop this note in the same PR. 
Someone upgrading from the last release can't call `ConvertExpr` any more, so 
the signature change only matters to them through the note below.
   
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to