iceberg-kitten opened a new pull request, #2650: URL: https://github.com/apache/iceberg-go/pull/2650
### What changes When a residual filter produces a nonempty Boolean mask with every row valid and selected, return a retained reference to the input Arrow batch. This avoids materializing a filtered copy for batches that already satisfy the residual. Arrow's existing filter handles null, mixed, empty and all-false masks. The fast path uses the mask's bitmap offset. ### Benchmark `BenchmarkArrowScanTaskResidual`, Go 1.26.3, Windows amd64, one pinned performance core, medians of four interleaved runs against `f7dc20d`. | Case | Base | This branch | Allocated bytes/op | | --- | ---: | ---: | ---: | | Identity predicate, evaluated | 19.54 ms | 15.49 ms | 8.16 MB → 7.21 MB | | Identity predicate, pre-eliminated | 10.29 ms | 10.01 ms | 4.97 MB → 4.97 MB | | Mixed predicate, amount residual | 12.96 ms | 13.69 ms | 7.70 MB → 7.71 MB | | Mixed predicate, original filter | 19.02 ms | 20.46 ms | 10.01 MB → 9.94 MB | The all-pass case used 92 fewer allocations per scan in the median. Mixed-mask timings varied in this run and need a repeat with fewer background processes. ### Correctness `go test ./table -run '^TestRecordFilterAllPassingBatch$'` passed. The test covers sliced batches, nulls, mixed masks, no matches, empty batches and ownership of retained records. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
