laskoviymishka commented on code in PR #2650:
URL: https://github.com/apache/iceberg-go/pull/2650#discussion_r4639900277
##########
table/arrow_scanner_test.go:
##########
@@ -40,6 +40,85 @@ import (
"github.com/stretchr/testify/require"
)
+func TestAllPassRecordMaskSlicedValidity(t *testing.T) {
+ mem := memory.NewCheckedAllocator(memory.DefaultAllocator)
+ defer mem.AssertSize(t, 0)
+ builder := array.NewBooleanBuilder(mem)
+ defer builder.Release()
+ builder.AppendValues([]bool{false, true, true, true, true},
[]bool{false, true, true, false, true})
+ values := builder.NewBooleanArray()
+ defer values.Release()
+
+ for _, tc := range []struct {
Review Comment:
Could these cases get a `name` and run under `t.Run`, like
`TestRecordFilterAllPassingBatch` below? As written, a failure at the
`allPassRecordMask` assertion doesn't say which slice broke. The `rows` loop in
`TestAllPassRecordMaskRejectsIncorrectRowCountsAndTypes` has the same gap: its
failure message doesn't include `rows`.
##########
table/arrow_scanner_test.go:
##########
@@ -40,6 +40,85 @@ import (
"github.com/stretchr/testify/require"
)
+func TestAllPassRecordMaskSlicedValidity(t *testing.T) {
+ mem := memory.NewCheckedAllocator(memory.DefaultAllocator)
+ defer mem.AssertSize(t, 0)
+ builder := array.NewBooleanBuilder(mem)
+ defer builder.Release()
+ builder.AppendValues([]bool{false, true, true, true, true},
[]bool{false, true, true, false, true})
+ values := builder.NewBooleanArray()
+ defer values.Release()
+
+ for _, tc := range []struct {
+ start, end int64
+ want bool
+ }{
+ {start: 1, end: 3, want: true},
+ {start: 1, end: 4, want: false},
+ {start: 4, end: 5, want: true},
+ } {
+ sliced := array.NewSlice(values, tc.start, tc.end)
+ mask := compute.NewDatumWithoutOwning(sliced)
+ require.Equal(t, array.UnknownNullCount, sliced.Data().NullN())
+ require.Equal(t, tc.want, allPassRecordMask(mask,
tc.end-tc.start))
+ sliced.Release()
Review Comment:
Could `sliced.Release()` be deferred right after `array.NewSlice`? If a
`require` above it fails, the slice keeps the parent's buffers alive and the
deferred `mem.AssertSize` reports a leak on top of the real failure.
`result.Release()` in
`TestRecordFilterStreamingAlternatesAllPassAndPartialBatches` has the same
shape, while `TestRecordFilterAllPassingBatch` already uses `defer
result.Release()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]