dramaticlly commented on PR #18932: URL: https://github.com/apache/iceberg/pull/18932#issuecomment-7021442056
> Thanks @dramaticlly for the PR! this is much easier to read. One question: 3.5, 4.0 and 4.1 still use `checkFileNum`. Do you plan to backport this in a follow-up? > > If so, could `RewriteTablePathResultAssert` live in iceberg-core's test artifacts instead of being copied into each Spark version? Thanks @huaxingao for the suggestion. The RewriteTablePathResultAssert does not contain spark specific logic and move to core does help simplify the spark tests across versions. I moved it to `org.apache.iceberg.actions` package, which is the same class as `RewriteTablePath.Result`, the class and methods are now public. I also included change of spark version 3.5/4.0/4.1/4.2 together as spark side of change is small, and src&byte-identical, please take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
