huaxingao commented on code in PR #18416:
URL: https://github.com/apache/iceberg/pull/18416#discussion_r4637022956


##########
format/expressions-spec.md:
##########
@@ -166,6 +166,7 @@ Primitive types are compared using signed comparison, 
except for the following t
 * `uuid` uses unsigned byte-wise comparison of the UUID bytes
 * `decimal` uses signed comparison independent of scale; this is equivalent to 
comparison of unscaled values because type alignment produces values with the 
same scale
 * `float` and `double` use IEEE 754 order for all non-NaN values; see below 
for NaN comparison rules
+* `vector` values use the equality rules defined in [Vector](spec.md#vector) 
and the ordering defined in [Sorting](spec.md#sorting) in the table spec

Review Comment:
   I think the rules for "equal" and "less than" don't agree for float vectors.
   
   Equality uses IEEE 754 order for all non-NaN values, where -0.0 and 0.0 are 
equal. But the Sorting order puts -0.0 before 0.0. So for a = [-0.0] and b = 
[0.0], the spec would say a = b and a < b are both true.
   
   can we make both rules agree with each other?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to