yyanyy commented on code in PR #18416: URL: https://github.com/apache/iceberg/pull/18416#discussion_r4649828280
########## format/expressions-spec.md: ########## @@ -166,6 +166,7 @@ Primitive types are compared using signed comparison, except for the following t * `uuid` uses unsigned byte-wise comparison of the UUID bytes * `decimal` uses signed comparison independent of scale; this is equivalent to comparison of unscaled values because type alignment produces values with the same scale * `float` and `double` use IEEE 754 order for all non-NaN values; see below for NaN comparison rules +* `vector` values use the equality rules defined in [Vector](spec.md#vector) and the ordering defined in [Sorting](spec.md#sorting) in the table spec Review Comment: thanks both, updated so that we are referring to float point's comparison rule which doesn't have this conflict. I was debating if we should support or block ordering, but eventually go with allowing it since it's trivial/intuitive to think about how to sort two vectors (apart from the small complication Huaxin mentioned) and blocking it explicitly feels more awkward to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
