laskoviymishka opened a new pull request, #2667:
URL: https://github.com/apache/iceberg-go/pull/2667

   Parsing `geometry(OGC:CRS84)` or `geography(OGC:CRS84, spherical)` went 
through `GeometryTypeOf` / `GeographyTypeOf`, which drop the defaults, so the 
types were written back as bare `geometry` and `geography`. The parser now 
validates through the constructors but keeps what was written. `Equals` 
compares `CRS()` and `Algorithm()`, so the explicit and implied defaults are 
still the same type. Bare `geometry` and `geography` are still written bare, 
and the constructors keep normalizing, so schemas inferred from Arrow don't 
change.
   
   New cases in `TestGeometryType` and `TestGeographyType` round-trip both 
strings through JSON and check `Equals` against the bare types in both 
directions. This covers the `geometry-crs84` and `geography-crs84-spherical` 
cases from the iceberg-verification type fixtures. Further cases pin 
`geography(OGC:CRS84)` (no `spherical` added), `geography(srid:4269, 
spherical)` and a mixed-case input.
   
   Always writing the parameters, as Java does, could be a follow-up.
   
   Part of apache/iceberg-verification#10.
   
   > AI-assisted, reviewed by a human.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to