rdblue commented on code in PR #19030:
URL: https://github.com/apache/iceberg/pull/19030#discussion_r4645301472


##########
core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java:
##########
@@ -362,6 +371,12 @@ private ManifestFile copyManifest(ManifestFile manifest) {
    */
   protected void validateAddedDataFiles(
       TableMetadata base, Long startingSnapshotId, PartitionSet partitionSet, 
Snapshot parent) {
+    Long parentId = parent != null ? parent.snapshotId() : null;
+    Preconditions.checkArgument(
+        base.formatVersion() < 4 || Objects.equals(parentId, 
startingSnapshotId),
+        "Cannot validate concurrent commit (%s) in v4 table",
+        parentId);

Review Comment:
   We will remove it when validations are implemented.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to