rdblue commented on code in PR #19030:
URL: https://github.com/apache/iceberg/pull/19030#discussion_r4647773701
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -2632,10 +2632,12 @@ public void
testCleanupUncommitedFilesForCleanableFailures() {
UpdateTableRequest body = (UpdateTableRequest) req.body();
MetadataUpdate.AddSnapshot addSnapshot =
(MetadataUpdate.AddSnapshot) body.updates().get(0);
- assertThatThrownBy(
- () ->
table.io().newInputFile(addSnapshot.snapshot().manifestListLocation()))
Review Comment:
This relied on incorrect behavior in `InMemoryFileIO` where you could not
create an `InputFile` unless the file existed. The correct behavior is to check
`InputFile#exists()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]