badalprasadsingh commented on code in PR #2669:
URL: https://github.com/apache/iceberg-go/pull/2669#discussion_r4646324195


##########
table/transaction_delete.go:
##########
@@ -995,6 +1006,8 @@ func (t *Transaction) writePositionDeletesForFiles(ctx 
context.Context, fs io.IO
                existingDVs[df.FilePath()] = entry.DataFile()
                existingDVBitmaps[df.FilePath()] = bitmap
        }
+       // A file without a DV starts from the positions its v2 position 
deletes removed.
+       maps.Copy(existingDVBitmaps, folded.seeds)

Review Comment:
   we need to add a test along with a note
   
   "maps.Copy" overwrites, so it relies on "foldPositionDeletes" skipping files 
with a dv, which no test covers -> without that skip, a second delete on a file 
that still has a shared v2 delete file brings back rows its dv deleted



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to