badalprasadsingh commented on code in PR #2669:
URL: https://github.com/apache/iceberg-go/pull/2669#discussion_r4646268063


##########
table/transaction_delete.go:
##########
@@ -1030,10 +1043,72 @@ func (t *Transaction) writePositionDeletesForFiles(ctx 
context.Context, fs io.IO
        for _, dvFile := range existingDVs {
                updater.removeDeletionVector(dvFile)
        }
+       for _, f := range folded.drop {
+               updater.removeDeleteFile(f)
+       }

Review Comment:
   removing these files makes the commit "non-replayable": if another writer 
commits first, the first delete after an upgrade now fails with 
"ErrCommitFailed" instead of retrying. the Delete docs (at 
transaction_delete.go lin287, and table.go line433) only mention dv removal -> 
can you please update both?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to