alexanderbianchi commented on code in PR #3739:
URL: https://github.com/apache/iceberg-rust/pull/3739#discussion_r4647286169


##########
crates/iceberg/Cargo.toml:
##########
@@ -58,6 +58,7 @@ derive_builder = { workspace = true }
 fastnum = { workspace = true }
 flate2 = { workspace = true }
 fnv = { workspace = true }
+foldhash = { workspace = true }

Review Comment:
   I can revert the last commit if we don't want this new dep. But this is what 
DF uses as well, and did benchmark better.
   
   ### Iceberg rust bench
   
   Workload | 400 keys, FNV → foldhash | 5,000 keys, FNV → foldhash
   -- | -- | --
   Evaluate an 8,192-row UTF-8 batch | 47.3 → 25.9 µs (−45%) | 46.0 → 26.5 µs 
(−42%)
   Scan 262,144 rows in one Parquet file | 3.05 → 2.31 ms (−24%) | 3.28 → 2.56 
ms (−22%)
   Scan the same rows across 64 files | 5.93 → 5.13 ms (−13%) | 6.96 → 6.20 ms 
(−11%)
   
   
   ### Datafusion Bench
   https://github.com/apache/datafusion-iceberg/pull/130
   Distinct keys | FNV | foldhash | Time saved
   -- | -- | -- | --
   32 | 11.27 ms | 5.65 ms | 50%
   400 | 15.09 ms | 7.87 ms | 48%
   1,000 | 14.25 ms | 8.56 ms | 40%
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to