alexanderbianchi commented on code in PR #3739:
URL: https://github.com/apache/iceberg-rust/pull/3739#discussion_r4648375103


##########
crates/iceberg/Cargo.toml:
##########
@@ -58,6 +58,7 @@ derive_builder = { workspace = true }
 fastnum = { workspace = true }
 flate2 = { workspace = true }
 fnv = { workspace = true }
+foldhash = { workspace = true }

Review Comment:
   adressed in 
https://github.com/apache/iceberg-rust/pull/3739/changes/6c9ea06589f1ca02e3f000e701327ea576a8624f
   benchmark in 
https://github.com/apache/iceberg-rust/commit/2d55fc4846e7e3b4d724f2721d99b9fce4adf74b



##########
crates/iceberg/Cargo.toml:
##########
@@ -58,6 +58,7 @@ derive_builder = { workspace = true }
 fastnum = { workspace = true }
 flate2 = { workspace = true }
 fnv = { workspace = true }
+foldhash = { workspace = true }

Review Comment:
   adressed in 
https://github.com/apache/iceberg-rust/pull/3739/changes/6c9ea06589f1ca02e3f000e701327ea576a8624f
   benchmark in 
https://github.com/apache/iceberg-rust/commit/2d55fc4846e7e3b4d724f2721d99b9fce4adf74b
   Description includes integer cases



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to