rdblue commented on code in PR #19030:
URL: https://github.com/apache/iceberg/pull/19030#discussion_r4648125248
##########
core/src/main/java/org/apache/iceberg/inmemory/InMemoryFileIO.java:
##########
@@ -56,11 +81,7 @@ public boolean fileExists(String location) {
@Override
public InputFile newInputFile(String location) {
Preconditions.checkState(!closed, "Cannot call newInputFile after calling
close()");
- byte[] contents = IN_MEMORY_FILES.get(location);
- if (null == contents) {
- throw new NotFoundException("No in-memory file found for location: %s",
location);
- }
- return new InMemoryInputFile(location, contents);
+ return new InMemoryInputFile(location, this);
Review Comment:
I mentioned this in a different comment, but the previous behavior violated
the `FileIO` contract so this is a bug fix to unblock the tests. And yes, we
use this for testing (and didn't have many tests depending on this behavior) so
I think it's okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]