rdblue commented on code in PR #16425:
URL: https://github.com/apache/iceberg/pull/16425#discussion_r4648449657


##########
format/spec.md:
##########
@@ -804,7 +807,7 @@ Each manifest type contains the following content:
 | v1-v3   | Data manifest   | Data files                                      
| Avro |
 | v2-v3   | Delete manifest | Delete files                                    
| Avro |
 | v4      | Root manifest   | Leaf manifests, data files, or v1-v3 manifests  
| Parquet |
-| v4      | Leaf manifest   | Data files and their colocated deletion vectors 
| Parquet |
+| v4      | Leaf manifest   | Data files, with their colocated deletion 
vectors and column files | Parquet |

Review Comment:
   ```suggestion
   | v4      | Leaf manifest   | Data files | Parquet |
   ```
   
   I think it is more clear to remove this rather than keep adding metadata 
fields to the list. Otherwise, this seems to imply that data files with 
colocated DVs or column files are only allowed in leaf manifests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to