rdblue commented on code in PR #16425:
URL: https://github.com/apache/iceberg/pull/16425#discussion_r4648500822


##########
format/spec.md:
##########
@@ -1203,13 +1206,13 @@ Values for `snapshot_id`, `sequence_number`, and 
`file_sequence_number` are inhe
 
 Manifests track the sequence number when a data or delete file was added to 
the table.
 
-The `sequence_number` field represents the data sequence number. It is set 
when a file is added to the dataset and must not change unless a column file is 
added. The data sequence number represents a relative age of the file content 
and should be used for planning which delete files apply to a data file.
+The `sequence_number` field represents the data sequence number. It is set 
when a file is added to the dataset and must not change unless a column file is 
added to a data file. The data sequence number represents a relative age of the 
file content and should be used for planning which delete files apply to a data 
file.

Review Comment:
   This sequence number is used for two things:
   - To determine the relative of the file content and whether delete files 
apply to a data file
   - To inherit row-level sequence numbers (`_last_updated_sequence_number`)
   
   I don't think that this makes much sense if you don't add the second use. 
That's the basis for updating the value: the data sequence number changes when 
a different value should be inherited by rows. As a result, the file-level age 
changes. To avoid moving data files ahead of equality deletes that apply to 
them, no equality deletes may remain after changing the data sequence number.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to