stevenzwu commented on code in PR #19019:
URL: https://github.com/apache/iceberg/pull/19019#discussion_r4650565177


##########
core/src/main/java/org/apache/iceberg/TrackingBuilder.java:
##########
@@ -97,6 +98,7 @@ private TrackingBuilder(Long newSnapshotId) {
     this.modifiedSnapshotId = null;
     this.deletedPositions = null;
     this.replacedPositions = null;
+    this.snapshotTimestampMicros = null;

Review Comment:
   Rewrites must copy non-null `_last_updated_sequence_number` and 
`_last_updated_timestamp` forward, so compacted rows don't inherit either 
value, and ADDED entries can stay null as #18526 specifies.



##########
api/src/main/java/org/apache/iceberg/ContentFile.java:
##########
@@ -197,6 +197,19 @@ default Long fileSequenceNumber() {
     return null;
   }
 
+  /**
+   * Returns the microsecond timestamp of the snapshot that added or changed 
this file.
+   *
+   * <p>The value is the snapshot's {@code timestamp-ms} converted to 
microseconds and is assigned
+   * at commit.
+   *
+   * <p>Returns null if the snapshot timestamp is unknown. This may happen for 
files in tables with
+   * format version below 4.
+   */
+  default Long snapshotTimestampMicros() {

Review Comment:
   renamed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to