amogh-jahagirdar commented on code in PR #19019:
URL: https://github.com/apache/iceberg/pull/19019#discussion_r4619536103


##########
api/src/main/java/org/apache/iceberg/ManifestFile.java:
##########
@@ -230,6 +230,11 @@ default Long firstRowId() {
     return null;
   }
 
+  /** Returns the microsecond timestamp of the snapshot that added the 
manifest file. */
+  default Long snapshotTimestampMicros() {

Review Comment:
   Ah yeah sorry I was thinking from a pure v4 mindset, for the older v1-v3 
manifests you're right they won't have this and we can't derive those because 
the snapshots for when those were written may have been expired. We could fill 
in a sentinel value (unix epoch) but that seems worse and error prone to 
interpretation when later materialized (compared to just leveraging the 
snapshot post v4 upgrade). So I think I'd leave it as is then



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to