rdblue commented on a change in pull request #1963:
URL: https://github.com/apache/iceberg/pull/1963#discussion_r569628011
##########
File path: core/src/main/java/org/apache/iceberg/avro/ValueWriters.java
##########
@@ -358,8 +380,10 @@ public void write(BigDecimal decimal, Encoder encoder)
throws IOException {
private final int nullIndex;
private final int valueIndex;
private final ValueWriter<T> valueWriter;
+ private final Schema.Type type;
+ private long nullValueCount;
- private OptionWriter(int nullIndex, ValueWriter<T> valueWriter) {
+ private OptionWriter(int nullIndex, ValueWriter<T> valueWriter,
Schema.Type type) {
Review comment:
It looks like the only place that `type` is used is in an error message.
I'd prefer not to change the signature here just to print a type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
