rdblue commented on a change in pull request #1963:
URL: https://github.com/apache/iceberg/pull/1963#discussion_r579890007
##########
File path: core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java
##########
@@ -244,6 +245,28 @@ static boolean hasProperty(Schema schema, String
propertyName) {
return schema.getObjectProp(propertyName) != null;
}
+ public static int fieldId(Schema currentSchema, Schema parentSchema,
Supplier<String> fieldNameGetter) {
Review comment:
I'd like to avoid needing this method because of the strange input
types. I think those show that the way we're traversing the schema isn't quite
right, which is why this is complicated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
