yyanyy commented on a change in pull request #2096:
URL: https://github.com/apache/iceberg/pull/2096#discussion_r570695154



##########
File path: core/src/main/java/org/apache/iceberg/SchemaParser.java
##########
@@ -134,6 +143,10 @@ static void toJson(Type type, JsonGenerator generator) 
throws IOException {
     }
   }
 
+  public static void toJsonWithVersion(Schema schema, JsonGenerator generator) 
throws IOException {

Review comment:
       Good point, will update




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to