yyanyy commented on a change in pull request #2096:
URL: https://github.com/apache/iceberg/pull/2096#discussion_r570695071
##########
File path: api/src/main/java/org/apache/iceberg/types/TypeUtil.java
##########
@@ -157,6 +157,21 @@ public static Schema assignFreshIds(Schema schema, NextID
nextId) {
.fields());
}
+ /**
+ * Assigns fresh ids from the {@link NextID nextId function} for all fields
in a schema.
Review comment:
Thanks for the catch! Will update
##########
File path: core/src/main/java/org/apache/iceberg/SchemaParser.java
##########
@@ -134,6 +143,10 @@ static void toJson(Type type, JsonGenerator generator)
throws IOException {
}
}
+ public static void toJsonWithVersion(Schema schema, JsonGenerator generator)
throws IOException {
Review comment:
Good point, will update
##########
File path: api/src/main/java/org/apache/iceberg/types/TypeUtil.java
##########
@@ -157,6 +157,21 @@ public static Schema assignFreshIds(Schema schema, NextID
nextId) {
.fields());
}
+ /**
+ * Assigns fresh ids from the {@link NextID nextId function} for all fields
in a schema.
Review comment:
Hmm actually I think either way may make sense? We either link `nextId
function` or `nextId` to `NextId` interface, and I think both are valid
interpretations? I'm also a bit hesitant to change since I copied this from
another method, and there are a few others that use this style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
