stevenzwu commented on a change in pull request #2105:
URL: https://github.com/apache/iceberg/pull/2105#discussion_r572620400
##########
File path: build.gradle
##########
@@ -317,19 +317,23 @@ project(':iceberg-flink') {
compile project(':iceberg-parquet')
compile project(':iceberg-hive-metastore')
+ compileOnly "org.apache.flink:flink-connector-base"
Review comment:
@tweise thx a lot for the context. now it all makes sense to me. Also
didn't notice that iceberg-flink-runtime actually exclude all flink jars.
Updated with compile deps.
In the future, if Flink decided to move `flink-connector-base` and
`flink-connector-files` into `flink-dist` (as hinted in FLINK-20472), we can
revisit the compile dep status.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
