stevenzwu commented on a change in pull request #2105:
URL: https://github.com/apache/iceberg/pull/2105#discussion_r571475350
##########
File path: build.gradle
##########
@@ -317,19 +317,23 @@ project(':iceberg-flink') {
compile project(':iceberg-parquet')
compile project(':iceberg-hive-metastore')
+ compileOnly "org.apache.flink:flink-connector-base"
Review comment:
Right now, the `iceberg-flink-runtime` shadow jar doesn't bring in any
Flink deps. if we include `flink-connector-base` as `compile`, then it will be
bundled in the `iceberg-flink-runtime` shadow. if a Flink app pulls in
`flink-connector-base` transitively via other deps (like Flink Kafka
connector), then we can get dup classes in jars.
@openinx maybe you can share some lights on how users get the Flink jars
when using the Flink Iceberg connector.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
