aokolnychyi commented on a change in pull request #2255: URL: https://github.com/apache/iceberg/pull/2255#discussion_r582155042
########## File path: api/src/main/java/org/apache/iceberg/actions/ActionsProvider.java ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import org.apache.iceberg.Table; + +/** + * An API that should be implemented by query engine integrations for providing actions. + */ +public interface ActionsProvider { Review comment: I am open to considering this idea but I am not sure it is going to help. It sounds like our `SparkProcedures` class. Loading by name/enum/class, will most likely give us a parent action interface, not a specific interface to call. Also, we will probably need to change how arguments are passed. And each time we add a new action, we will have to add a new constant to the enum, which is more or less equivalent to adding a new method here with a default implementation. I see this API kind of close to our `Table` API. That one also has a number of methods but it is pretty convenient. That said, I do get the concern of having a lot of methods in this API but we can address it differently. For example, we will support multiple compaction strategies. Instead of offering a separate action for each type, we can make the configuration flexible. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
