rdblue commented on a change in pull request #2255: URL: https://github.com/apache/iceberg/pull/2255#discussion_r582162516
########## File path: api/src/main/java/org/apache/iceberg/actions/ActionsProvider.java ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import org.apache.iceberg.Table; + +/** + * An API that should be implemented by query engine integrations for providing actions. + */ +public interface ActionsProvider { Review comment: I agree with Anton here. If we were to load by name, we wouldn't get a specific interface to configure the action. We could get the interface if we loaded by passing in the interface, but then I don't see how we'd be much better off. The API would be awkward (you have to find and supply the action interface you want) and the benefit is avoiding a few methods here. I think what Anton has in the PR is a good step forward instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
