zhangjun0x01 commented on a change in pull request #2258:
URL: https://github.com/apache/iceberg/pull/2258#discussion_r583327547
##########
File path: core/src/main/java/org/apache/iceberg/BaseFile.java
##########
@@ -434,7 +433,7 @@ public Integer sortOrderId() {
if (map != null) {
Map<K, V> copy = Maps.newHashMapWithExpectedSize(map.size());
copy.putAll(map);
- return Collections.unmodifiableMap(copy);
Review comment:
Mainly, we use the `CombinedScanTask` class in many places, such as
[RowDataIterator](https://github.com/apache/iceberg/blob/master/flink/src/main/java/org/apache/iceberg/flink/source/RowDataIterator.java#L57)
for reading data. The bottom layer of the `CombinedScanTask ` class contains
`BaseFile`. When we doing deserialize, because we cannot put the data into
unmodifiableMap, it causes an exception , the deserialization failed, causing
the program to fail. I tried other methods, but I did not find a suitable
solution for the time being
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
