openinx commented on a change in pull request #2258:
URL: https://github.com/apache/iceberg/pull/2258#discussion_r595682774
##########
File path: core/src/main/java/org/apache/iceberg/BaseFile.java
##########
@@ -434,7 +433,7 @@ public Integer sortOrderId() {
if (map != null) {
Map<K, V> copy = Maps.newHashMapWithExpectedSize(map.size());
copy.putAll(map);
- return Collections.unmodifiableMap(copy);
Review comment:
The only way that I could think of is replacing the `Map<Integer, Long>`
to an self-defined immutable map which won't implement the `java.util.Map`
interface, in this way we don't have to depend on the kryo's internal
`MapSerializer` (It will call the `put` to add element into immutable
collection).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
