RussellSpitzer commented on a change in pull request #2282:
URL: https://github.com/apache/iceberg/pull/2282#discussion_r584893410



##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -193,6 +204,8 @@ private Expression filterExpression() {
 
   private StructType lazyType() {
     if (type == null) {
+      Preconditions.checkArgument(readTimestampWithoutZone || 
!hasTimestampWithoutZone(lazySchema()),
+              "Spark does not support timestamp without time zone fields");

Review comment:
       I would like this to be a bit more elaborate. Something like
   "Cannot handle **timestamp without timezone** fields in Spark. Spark does 
not natively support this type but if you would like to handle all 
**timestamps** as **timestamp with timezone** set 'flag name' to true. This 
will not change the underlying values stored but will change their displayed 
values in Spark. For more information see ... `some website reference?`"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to