bkahloon commented on pull request #2282: URL: https://github.com/apache/iceberg/pull/2282#issuecomment-788176576
> Also nit, you'll probably want to fetch apache master and rebase this branch that to drop the "merge 1 commit" from the commits in the PR I can make the changes you mentioned and also open a new PR and comply with the project's commit history standards. I think I missed a few things that you mentioned and also not prefixing my commits with the project that the commits relate to (i.e. `spark:`). Should I open a new PR after making the changes and close this one ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
