aokolnychyi commented on a change in pull request #2287:
URL: https://github.com/apache/iceberg/pull/2287#discussion_r586834813
##########
File path:
spark/src/main/java/org/apache/iceberg/actions/ExpireSnapshotsAction.java
##########
@@ -210,7 +210,8 @@ public ExpireSnapshotsAction deleteWith(Consumer<String>
newDeleteFunc) {
}
@Override
- public ExpireSnapshotsActionResult execute() {
+ public ExpireSnapshotsActionResult doExecute() {
+ spark.sparkContext().setJobGroup("EXPIRE", "EXPIRE-SNAPSHOTS", false);
Review comment:
+1 on this idea. I think we should add an abstract method to
`BaseSparkAction` like @rymurr suggests:
```
protected abstract JobGroupInfo jobGroup();
```
Then we just need to rename `execute` to `doExecute` in actions and set
`jobGroup` in `BaseSparkAction`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
