aokolnychyi commented on a change in pull request #2287:
URL: https://github.com/apache/iceberg/pull/2287#discussion_r586921306
##########
File path:
spark/src/main/java/org/apache/iceberg/actions/ExpireSnapshotsAction.java
##########
@@ -210,7 +210,8 @@ public ExpireSnapshotsAction deleteWith(Consumer<String>
newDeleteFunc) {
}
@Override
- public ExpireSnapshotsActionResult execute() {
+ public ExpireSnapshotsActionResult doExecute() {
+ spark.sparkContext().setJobGroup("EXPIRE", "EXPIRE-SNAPSHOTS", false);
Review comment:
Data compaction action may submit multiple jobs (e.g. one job per
partition) and we would want to have different descriptions for each job (e.g.
include the partition we compact in each). Maybe, the abstract method won't
work that well in that case.
@RussellSpitzer, thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
