bkahloon commented on a change in pull request #2282:
URL: https://github.com/apache/iceberg/pull/2282#discussion_r587123994
##########
File path: spark/src/main/java/org/apache/iceberg/spark/TypeToSparkType.java
##########
@@ -104,12 +104,7 @@ public DataType primitive(Type.PrimitiveType primitive) {
throw new UnsupportedOperationException(
"Spark does not support time fields");
case TIMESTAMP:
- Types.TimestampType timestamp = (Types.TimestampType) primitive;
- if (timestamp.shouldAdjustToUTC()) {
- return TimestampType$.MODULE$;
- }
- throw new UnsupportedOperationException(
- "Spark does not support timestamp without time zone fields");
Review comment:
I think this might involve a bigger refactor, including changing the
method signature to accept the flag to `.primitive(...,
handleTimestampWithoutTimezoneFlag)`. I'm not sure if that will break other
stuff. I added in the logic as comments for now as to how to implement it after
we can settle on the implementation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
