aokolnychyi commented on a change in pull request #2287:
URL: https://github.com/apache/iceberg/pull/2287#discussion_r590629779
##########
File path: spark/src/main/java/org/apache/iceberg/actions/BaseSparkAction.java
##########
@@ -50,6 +53,24 @@
protected abstract Table table();
+ protected abstract R doExecute();
+
+ protected abstract JobGroupInfo jobGroup();
Review comment:
@rymurr, do you mean making `JobGroupInfo` implement `AutoCloseable` and
setting the new job description in the constructor?
```
public ... execute() {
try (JobGroupInfo ignored = newJobGroupInfo(...)) {
doExecute();
}
}
```
If yes, both approaches work for me, I have no preference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
