pvary commented on a change in pull request #2075:
URL: https://github.com/apache/iceberg/pull/2075#discussion_r592240739
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java
##########
@@ -45,6 +46,7 @@
public HiveClientPool(int poolSize, Configuration conf) {
super(poolSize, TTransportException.class);
this.hiveConf = new HiveConf(conf, HiveClientPool.class);
+ this.hiveConf.addResource(conf);
Review comment:
It is strange that we have to provide the `conf` twice in this case.
Do I understand correctly that this is because of the precedence? So in the
constructor we set the `conf` properties, then initialize based on the class,
but we would like to have the `conf` values higher priority than ones stored in
the jars?
Would this work?
```
this.hiveConf = new HiveConf(HiveClientPool.class);
this.hiveConf.addResource(conf);
```
Sorry to forgot about this PR (had little bit too much in the air) 😢
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
