pvary commented on a change in pull request #2075:
URL: https://github.com/apache/iceberg/pull/2075#discussion_r592949567
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java
##########
@@ -45,6 +46,7 @@
public HiveClientPool(int poolSize, Configuration conf) {
super(poolSize, TTransportException.class);
this.hiveConf = new HiveConf(conf, HiveClientPool.class);
+ this.hiveConf.addResource(conf);
Review comment:
> new HiveConf(conf, HiveClientPool.class) will copy all the overlay
properties in conf and new HiveConf(HiveClientPool.class) will not.
I agree with your assessment above. My guess is that
`this.hiveConf.addResource(conf);` will add the overlay properties too (might
be wrong, just asking). If this statement is right we might not need to add it
twice.
Thanks, Peter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
