dixingxing0 commented on a change in pull request #2075:
URL: https://github.com/apache/iceberg/pull/2075#discussion_r592885852
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java
##########
@@ -45,6 +46,7 @@
public HiveClientPool(int poolSize, Configuration conf) {
super(poolSize, TTransportException.class);
this.hiveConf = new HiveConf(conf, HiveClientPool.class);
+ this.hiveConf.addResource(conf);
Review comment:
Hi peter, your code works fine under this test, but `new HiveConf(conf,
HiveClientPool.class)` will copy all the `overlay` properties in `conf` and
`new HiveConf(HiveClientPool.class)` will not.
In this test these two properties will be record in `overlay` properties
(have higher priority):
```java
conf.set(HiveConf.ConfVars.METASTOREWAREHOUSE.varname, "file:/mywarehouse/");
conf.setInt("iceberg.hive.client-pool-size", 10);
```
So i think we should keep using `new HiveConf(conf, HiveClientPool.class)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
