dixingxing0 commented on a change in pull request #2075:
URL: https://github.com/apache/iceberg/pull/2075#discussion_r592955587
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java
##########
@@ -45,6 +46,7 @@
public HiveClientPool(int poolSize, Configuration conf) {
super(poolSize, TTransportException.class);
this.hiveConf = new HiveConf(conf, HiveClientPool.class);
+ this.hiveConf.addResource(conf);
Review comment:
As i tested, `this.hiveConf.addResource(conf)` will not copy the overlay
properties, the test can still pass, but `this.hiveConf.overlay` will not
contains the origin overlay properties in `conf`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
