aokolnychyi commented on pull request #2287: URL: https://github.com/apache/iceberg/pull/2287#issuecomment-797836912
I gave it a round of testing and it seems we overlooked the fact that each action will get a new counter. I think the counter should be a static variable: ``` private static final AtomicInteger JOB_COUNTER = new AtomicInteger(); ``` Also, there seems to be a style violation. @karuppayya, could you update those, please? LGTM otherwise. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
