aokolnychyi commented on a change in pull request #2287:
URL: https://github.com/apache/iceberg/pull/2287#discussion_r594677710
##########
File path: spark/src/main/java/org/apache/iceberg/actions/BaseSparkAction.java
##########
@@ -50,6 +55,7 @@
private final SparkSession spark;
private final JavaSparkContext sparkContext;
+ private static final AtomicInteger jobCounter = new AtomicInteger();
Review comment:
Since this is a static variable now, should we move it up and use
`JOB_COUNTER` as the name?
I'd also add an empty line to separate static and instance variables like
this:
```
private static final AtomicInteger JOB_COUNTER = new AtomicInteger();
private final SparkSession spark;
private final JavaSparkContext sparkContext;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
