rdblue commented on a change in pull request #2314:
URL: https://github.com/apache/iceberg/pull/2314#discussion_r595601245
##########
File path:
spark/src/main/java/org/apache/iceberg/actions/ExpireSnapshotsAction.java
##########
@@ -56,44 +36,15 @@
* require a shuffle so parallelism can be controlled through
spark.sql.shuffle.partitions. The expiration is done
* locally using a direct call to RemoveSnapshots. The snapshot expiration
will be fully committed before any deletes
* are issued. Deletes are still performed locally after retrieving the
results from the Spark executors.
+ *
+ * @deprecated since 0.12.0
Review comment:
We should also tell the reader what to use instead and when to expect
this to be removed. That also helps us find things that should be removed for a
release by grepping for "will be removed in 0.13.0".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
