aokolnychyi commented on a change in pull request #2314: URL: https://github.com/apache/iceberg/pull/2314#discussion_r595636768
########## File path: core/src/main/java/org/apache/iceberg/actions/BaseExpireSnapshotsActionResult.java ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +public class BaseExpireSnapshotsActionResult implements ExpireSnapshots.Result { Review comment: I am fine converting `Result` into a class but I am not sure we will gain much by doing that. The current class is in the core module so it is accessible to everyone. Making `Result` a class may make inheritance a bit harder. I do like our current pattern of having `BaseXXX` classes in core and interfaces in the API module. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
