pvary commented on a change in pull request #2228:
URL: https://github.com/apache/iceberg/pull/2228#discussion_r598600194
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergOutputCommitter.java
##########
@@ -223,6 +225,9 @@ private JobConf jobConf(Table table, int taskNum) {
conf.setNumMapTasks(taskNum);
conf.setNumReduceTasks(0);
conf.set(HiveConf.ConfVars.HIVEQUERYID.varname, QUERY_ID);
+ Map<String, String> outputs = Maps.newHashMap();
+ outputs.put(table.location(), table.name());
Review comment:
Test only issue. The test only run for HadoopTables where the `location`
and the `name` is the same. Fixed this.
Also we have tests for different `Catalog` implementations where these are
different, so the production code is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
