rdblue commented on a change in pull request #2228:
URL: https://github.com/apache/iceberg/pull/2228#discussion_r600019062
##########
File path: mr/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java
##########
@@ -58,8 +58,11 @@ private InputFormatConfig() {
public static final String LOCATION_PROVIDER =
"iceberg.mr.location.provider";
public static final String ENCRYPTION_MANAGER =
"iceberg.mr.encription.manager";
- public static final String COMMIT_THREAD_POOL_SIZE =
"iceberg.mr.commit.thread.pool.size";
- public static final int COMMIT_THREAD_POOL_SIZE_DEFAULT = 10;
+ public static final String OUTPUT_TABLES = "iceberg.mr.output.tables";
+ public static final String COMMIT_TABLE_THREAD_POOL_SIZE =
"iceberg.mr.commit.table.thread.pool.size";
Review comment:
I would keep it simple until we have a need for parallelism. I expect
the commits to be much faster than the actual execution, so I don't think that
it will be a very significant delay if we do them serially. Probably better to
avoid complexity until we need it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
