omaraloraini edited a comment on pull request #2336: URL: https://github.com/apache/iceberg/pull/2336#issuecomment-804491609
Old Ran 10 trials: mean time: 5781.100 ms, stddev: 78.045 ms New without setter: Ran 10 trials: mean time: 5166.300 ms, stddev: 61.861 ms. [commit](https://github.com/omaraloraini/iceberg/commit/69a11fd7d99e161fc4e3a997caecef0f601ba114). I update the schema in the test with more required and primitive columns, new schema: ``` Schema structSchema = new Schema( required(1, "circumvent", Types.LongType.get()), optional(2, "antarctica", Types.StringType.get()), optional(3, "fluent", Types.DoubleType.get()), required(4, "quell", Types.StructType.of( required(5, "operator", Types.BooleanType.get()), optional(6, "fanta", Types.IntegerType.get()), optional(7, "cable", Types.FloatType.get()) )), required(8, "chimney", Types.TimestampType.withZone()), required(9, "wool", Types.DateType.get()), required(10, "c1", Types.LongType.get()), required(11, "c2", Types.LongType.get()), required(12, "c3", Types.LongType.get()), required(13, "c4", Types.IntegerType.get()), required(14, "c5", Types.IntegerType.get()), required(15, "c6", Types.IntegerType.get()), required(16, "c7", Types.FloatType.get()), required(17, "c8", Types.FloatType.get()), required(18, "c9", Types.DoubleType.get()), required(19, "c10", Types.DoubleType.get()) ); ``` Result with new schema: Old: Ran 10 trials: mean time: 7528.300 ms, stddev: 97.378 ms New without setter: Ran 10 trials: mean time: 9742.600 ms, stddev: 97.785 ms New with setter!: Ran 10 trials: mean time: 3939.400 ms, stddev: 98.521 ms -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
