rdblue commented on pull request #2336: URL: https://github.com/apache/iceberg/pull/2336#issuecomment-805246901
@omaraloraini, nice work! I think that the "new with setter" option looks promising! While it's true that Spark and Flink will currently store the data in `Object[]` that doesn't mean that we won't support an object model that handles primitives. And even then, the Parquet/Avro code will use Avro generics that also store values in `Object[]` and that appears to be much faster! What do you think about re-opening this and updating it to "new with setter" so we can take advantage of any performance improvements we might see? We can also copy the micro-benchmark you're running over to Spark and Flink to see if it does work there as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
