jackye1995 commented on a change in pull request #2333:
URL: https://github.com/apache/iceberg/pull/2333#discussion_r599983125
##########
File path: core/src/test/java/org/apache/iceberg/TestCatalogUtil.java
##########
@@ -123,6 +123,16 @@ public void loadCustomFileIO_noArg() {
Assert.assertEquals(properties, ((TestFileIONoArg) fileIO).map);
}
+ @Test
+ public void loadCustomFileIO_hadoopConfigConstructor() {
+ Configuration configuration = new Configuration();
+ configuration.set("key", "val");
+ FileIO fileIO = CatalogUtil.loadFileIO(
+ TestFileIOHadoopConstructor.class.getName(), Maps.newHashMap(),
configuration);
Review comment:
I don't think that would be possible, since HadoopFileIO is public and
the constructor is also public, we cannot simply change it. But this is a good
point, I can just load it instead of having this dummy test class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
